forked from marfrit/libva-v4l2-request-fourier
test0r
0a3432ad64
Chromium's vaapi_video_decoder may call vaCreateContext with surfaces=NULL, surfaces_count=0 and then create surfaces afterwards via vaCreateSurfaces2. In that order driver_data->video_format is still NULL when CreateContext runs and our early `video_format == NULL` guard returns OPERATION_FAILED. Confirmed via temporary request_log() — Brave hits exactly that path on ohm. Move the probe out of RequestCreateSurfaces into a new video_format_probe() helper in video.c, and call it eagerly from RequestInit. RequestCreateSurfaces still re-probes if init came up NULL, which preserves the original lazy behaviour for any caller that needs it. Also small clean-up of surface.c since the probe block moved out: drop the now-dead `bool found` local. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
46 lines
1.6 KiB
C
46 lines
1.6 KiB
C
/*
|
|
* Copyright (C) 2018 Paul Kocialkowski <paul.kocialkowski@bootlin.com>
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the
|
|
* "Software"), to deal in the Software without restriction, including
|
|
* without limitation the rights to use, copy, modify, merge, publish,
|
|
* distribute, sub license, and/or sell copies of the Software, and to
|
|
* permit persons to whom the Software is furnished to do so, subject to
|
|
* the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the
|
|
* next paragraph) shall be included in all copies or substantial portions
|
|
* of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.
|
|
* IN NO EVENT SHALL PRECISION INSIGHT AND/OR ITS SUPPLIERS BE LIABLE FOR
|
|
* ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
|
|
* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
|
|
* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#ifndef _VIDEO_H_
|
|
#define _VIDEO_H_
|
|
|
|
#include <stdbool.h>
|
|
|
|
struct video_format {
|
|
char *description;
|
|
unsigned int v4l2_format;
|
|
unsigned int v4l2_buffers_count;
|
|
bool v4l2_mplane;
|
|
unsigned int drm_format;
|
|
uint64_t drm_modifier;
|
|
unsigned int planes_count;
|
|
unsigned int bpp;
|
|
};
|
|
|
|
struct video_format *video_format_find(unsigned int pixelformat, bool mplane);
|
|
struct video_format *video_format_probe(int video_fd);
|
|
bool video_format_is_linear(struct video_format *format);
|
|
|
|
#endif
|