validate tool names at tools_schema() against strictest provider regex #32

New Issue

2026-05-12T20:40:49Z

claude-noether commented

2026-05-12 20:40:49 +00:00

Context

During Phase 2 verify (TC #26 against :model cloud), an actual HTTP 400 from openrouter→Amazon Bedrock surfaced the constraint:

^[a-zA-Z0-9_-]{1,128}$

We fixed it by switching the alias separator from . to __ (commit f26cbd9). But the validation gap is generic — a future MCP server could register a tool with a name containing characters outside this regex (e.g. read-file:v2, tool.fast), and aish would emit it on the wire only to be rejected by a strict provider.

Ask

In repl.lua::tools_schema() (or mcp.lua::list_tools), validate each alias .. "__" .. t.name against the Bedrock regex before emitting. On violation: log a startup status ([aish] tool X has name characters outside ^[a-zA-Z0-9_-]+$; will fail with strict providers) and either:

skip the offending tool from the schema (safest)
emit anyway with the warning (informative)

Picking the policy needs a Q in the manifest if Norris/Phase 3 reaches for the same area.

Why now

Not blocking — Phase 2 v1 ships fine with the manual __ convention. But the gap is shaped like a footgun: a user adds an MCP server with non-conformant tool names and gets the same uninformative breakage we just walked through. Validation is ~6 lines, runs once per session, no perf concern.

## Context During Phase 2 verify (TC #26 against `:model cloud`), an actual HTTP 400 from openrouter→Amazon Bedrock surfaced the constraint: ``` ^[a-zA-Z0-9_-]{1,128}$ ``` We fixed it by switching the alias separator from `.` to `__` (commit f26cbd9). But the validation gap is generic — a future MCP server could register a tool with a name containing characters outside this regex (e.g. `read-file:v2`, `tool.fast`), and aish would emit it on the wire only to be rejected by a strict provider. ## Ask In `repl.lua::tools_schema()` (or `mcp.lua::list_tools`), validate each `alias .. "__" .. t.name` against the Bedrock regex before emitting. On violation: log a startup status (`[aish] tool X has name characters outside ^[a-zA-Z0-9_-]+$; will fail with strict providers`) and either: - skip the offending tool from the schema (safest) - emit anyway with the warning (informative) Picking the policy needs a Q in the manifest if Norris/Phase 3 reaches for the same area. ## Why now Not blocking — Phase 2 v1 ships fine with the manual `__` convention. But the gap is shaped like a footgun: a user adds an MCP server with non-conformant tool names and gets the same uninformative breakage we just walked through. Validation is ~6 lines, runs once per session, no perf concern.

claude-noether added the feature request label 2026-05-12 20:40:49 +00:00

claude-noether referenced this issue from a commit

2026-05-16 21:06:44 +00:00

repl: validate MCP tool names against Bedrock regex (closes #32)

claude-noether closed this issue

2026-05-16 21:06:44 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: marfrit/aish#32