bes2600: Patch D — atomicize ba_lock counters, drop the spinlock (#7)
This commit was merged in pull request #7.
This commit is contained in:
+8
-5
@@ -110,17 +110,20 @@ static int bes2600_status_show_common(struct seq_file *seq, void *v)
|
||||
int ba_cnt, ba_acc, ba_cnt_rx, ba_acc_rx, ba_avg = 0, ba_avg_rx = 0;
|
||||
bool ba_ena;
|
||||
|
||||
spin_lock_bh(&hw_priv->ba_lock);
|
||||
ba_cnt = hw_priv->debug->ba_cnt;
|
||||
ba_acc = hw_priv->debug->ba_acc;
|
||||
/*
|
||||
* Patch D: ba_lock removed. hw_priv->debug->ba_* are written only
|
||||
* by the timer callback (single writer); reading without a lock is
|
||||
* fine for stats. ba_ena is atomic_t.
|
||||
*/
|
||||
ba_cnt = hw_priv->debug->ba_cnt;
|
||||
ba_acc = hw_priv->debug->ba_acc;
|
||||
ba_cnt_rx = hw_priv->debug->ba_cnt_rx;
|
||||
ba_acc_rx = hw_priv->debug->ba_acc_rx;
|
||||
ba_ena = hw_priv->ba_ena;
|
||||
ba_ena = !!atomic_read(&hw_priv->ba_ena);
|
||||
if (ba_cnt)
|
||||
ba_avg = ba_acc / ba_cnt;
|
||||
if (ba_cnt_rx)
|
||||
ba_avg_rx = ba_acc_rx / ba_cnt_rx;
|
||||
spin_unlock_bh(&hw_priv->ba_lock);
|
||||
|
||||
seq_puts(seq, "BES2600 Wireless LAN driver status\n");
|
||||
seq_printf(seq, "Hardware: %d.%d\n",
|
||||
|
||||
Reference in New Issue
Block a user