marfrit/bes2600-dkms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bes2600: Patch G — restore SPDX + ST-Ericsson attribution chain #6

Merged
marfrit merged 1 commits from bes2600/license-spdx-restore-attribution into cleanups 2026-05-07 22:11:15 +00:00
Conversation 0 Commits 1 Files Changed 48
+223 -292
claude-noether commented 2026-05-07 22:03:51 +00:00
Collaborator
Copy Link
Copy Source

License/copyright correction. bes2600 is a fork of cw1200 (drivers/net/wireless/st/cw1200/, ST-Ericsson, Dmitry Tarnyagin 2010-2011). The fork's file headers had GPL-compliance gaps:

What was wrong

  • 0 of 48 files carried SPDX-License-Identifier (cw1200 mainline has them on all 25)
  • Original Copyright (c) 2010, ST-Ericsson lines were stripped and replaced with Copyright (c) 2010, Bestechnic — factually impossible and a GPL-2.0 §1 attribution-preservation violation
  • MODULE_AUTHOR("Dmitry Tarnyagin <dmitry.tarnyagin@stericsson.com>") declared in the module init contradicted the file-level copyright claims
  • Legacy GPL-2.0 boilerplate paragraph was duplicating what SPDX expresses

What this patch does

  • Adds SPDX-License-Identifier on every .c/.h (48 files)
  • Restores ST-Ericsson + Tarnyagin attribution on all 22 files with cw1200 ancestry (bh.{c,h}, debug.{c,h}, fwio.{c,h}, hwio.{c,h}, main.c, pm.{c,h}, queue.{c,h}, scan.{c,h}, sta.{c,h}, txrx.{c,h}, wsm.{c,h})
  • Keeps Bestechnic copyright on subsequent chain entries
  • Notes derivation lineage on bes2600_sdio.c (← cw1200_sdio.c) and sbus.h (← hwbus.h)
  • Preserves prism54 (Michael Wu 2006) + islsm (Jean-Baptiste Note 2004-2006) chain on main.c and bes2600.h
  • Drops the legacy GPL-2.0 boilerplate paragraph in favour of SPDX

Diff scope

48 files; 223+/-292 lines. All changes are in file-header comment blocks. No code change. Module build is unaffected.

Why this matters

  • Required for any kernel.org submission attempt (mainlining is the long-term goal). Maintainers will auto-bounce PRs without SPDX.
  • GPL-2.0 §1 attribution preservation — "keep intact all the notices that refer to this License" — copyright notices fall under this requirement.
  • Tarnyagin (now at lockless.no) is the actual author of the inherited code; restoring his name is a basic GPL hygiene step.

Test plan

  • Build module on ohm sandbox (header-only diff, expect zero regressions)
  • Smoke-test bes2600.ko load + association
  • No Phase 7 stress ramp needed — pure metadata change

Rollback

Not expected to be needed. If anything goes wrong, git revert of this commit gets back the pre-Patch-G headers (still functionally GPL-compatible, just with the issues documented above).

License/copyright correction. bes2600 is a fork of cw1200 (drivers/net/wireless/st/cw1200/, ST-Ericsson, Dmitry Tarnyagin 2010-2011). The fork's file headers had GPL-compliance gaps: ## What was wrong - **0 of 48 files** carried SPDX-License-Identifier (cw1200 mainline has them on all 25) - Original `Copyright (c) 2010, ST-Ericsson` lines were **stripped** and replaced with `Copyright (c) 2010, Bestechnic` — factually impossible and a GPL-2.0 §1 attribution-preservation violation - `MODULE_AUTHOR("Dmitry Tarnyagin <dmitry.tarnyagin@stericsson.com>")` declared in the module init contradicted the file-level copyright claims - Legacy GPL-2.0 boilerplate paragraph was duplicating what SPDX expresses ## What this patch does - Adds SPDX-License-Identifier on every .c/.h (48 files) - Restores ST-Ericsson + Tarnyagin attribution on all 22 files with cw1200 ancestry (bh.{c,h}, debug.{c,h}, fwio.{c,h}, hwio.{c,h}, main.c, pm.{c,h}, queue.{c,h}, scan.{c,h}, sta.{c,h}, txrx.{c,h}, wsm.{c,h}) - Keeps Bestechnic copyright on subsequent chain entries - Notes derivation lineage on bes2600_sdio.c (← cw1200_sdio.c) and sbus.h (← hwbus.h) - Preserves prism54 (Michael Wu 2006) + islsm (Jean-Baptiste Note 2004-2006) chain on main.c and bes2600.h - Drops the legacy GPL-2.0 boilerplate paragraph in favour of SPDX ## Diff scope 48 files; 223+/-292 lines. All changes are in file-header comment blocks. No code change. Module build is unaffected. ## Why this matters - **Required for any kernel.org submission attempt** (mainlining is the long-term goal). Maintainers will auto-bounce PRs without SPDX. - **GPL-2.0 §1 attribution preservation** — "keep intact all the notices that refer to this License" — copyright notices fall under this requirement. - Tarnyagin (now at lockless.no) is the actual author of the inherited code; restoring his name is a basic GPL hygiene step. ## Test plan - [ ] Build module on ohm sandbox (header-only diff, expect zero regressions) - [ ] Smoke-test bes2600.ko load + association - [ ] No Phase 7 stress ramp needed — pure metadata change ## Rollback Not expected to be needed. If anything goes wrong, `git revert` of this commit gets back the pre-Patch-G headers (still functionally GPL-compatible, just with the issues documented above).
claude-noether added 1 commit 2026-05-07 22:03:52 +00:00
bes2600: Patch G — restore SPDX identifiers + ST-Ericsson attribution 8dd79199f8 
The bes2600 driver is a fork of the upstream cw1200 driver
(drivers/net/wireless/st/cw1200/, ST-Ericsson, Dmitry Tarnyagin
2010-2011).  The fork's file headers have three GPL-compliance issues:

  1. NO SPDX-License-Identifier on any of 48 source files (cw1200
     mainline has them on all 25).  kernel.org-mandated since 2017.

  2. Original "Copyright (c) 2010, ST-Ericsson" lines stripped from
     all files inherited from cw1200, replaced with
     "Copyright (c) 2010, Bestechnic" — factually impossible
     (Bestechnic did not author the 2010 work) and a GPL-2.0 §1
     attribution-preservation violation.

  3. The "GPL version 2 as published by the Free Software Foundation"
     boilerplate paragraph is redundant alongside SPDX and is the
     legacy form modern kernel sources have replaced.

This patch corrects all three for the 48 .c/.h files in bes2600/:

  - Adds `// SPDX-License-Identifier: GPL-2.0-only` (or `/* ... */`
    for headers) as line 1 of every file.
  - Restores `Copyright (c) 2010, ST-Ericsson` + `Author: Dmitry
    Tarnyagin <dmitry.tarnyagin@lockless.no>` as the FIRST copyright
    chain entry on all 22 files derived from cw1200 (bh.{c,h},
    debug.{c,h}, fwio.{c,h}, hwio.{c,h}, main.c, pm.{c,h},
    queue.{c,h}, scan.{c,h}, sta.{c,h}, txrx.{c,h}, wsm.{c,h}).
  - Keeps `Copyright (c) 2022, Bestechnic (Beijing) Co., Ltd.` as
    the SECOND chain entry where Bestechnic genuinely contributed.
  - Notes "Derived from cw1200_sdio.c" + ST-Ericsson copyright on
    bes2600_sdio.c (heavy derivation, not a literal rename).
  - Notes "Replaces hwbus.h from cw1200/" + ST-Ericsson copyright
    on sbus.h.
  - Preserves the prism54/islsm authorship chain on main.c and
    bes2600.h (Michael Wu 2006 + Jean-Baptiste Note 2004-2006).
  - Drops the GPL-2.0 boilerplate paragraph in favour of SPDX.

No code changes — only file-header comment blocks.  Module build is
unaffected (verified by header-only diff scope).

This is a prerequisite for any kernel.org submission attempt.  The
existing MODULE_LICENSE("GPL") + MODULE_AUTHOR(Tarnyagin@stericsson.com)
declarations were already present and are unchanged here; the
mismatch between MODULE_AUTHOR and the (since-corrected) per-file
copyrights is now resolved.
marfrit merged commit 25c0ed8c57 into cleanups 2026-05-07 22:11:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude-noether (Claude (noether)) marfrit (Markus Fritsche)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marfrit/bes2600-dkms#6
Delete Branch "bes2600/license-spdx-restore-attribution"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?