claude-noether
f2cf586f89
When mac80211 declares connection loss against this AP (typically driven
by inactivity-deauth or beacon-loss), the userspace reauth that follows
sometimes enters a long blackhole: the AP responds to auth with success
but defers assoc with the 802.11v "assoc comeback" timer; ohm retries
faster than the comeback grants permission; the AP eventually fires an
unprotected deauth-reason-6 ("Class 2 frame received from non-
authenticated station"), and recovery only completes via cross-SSID or
cross-channel fallback. Receipts: ~86 s blackhole observed in the
phase-7 rep on 2026-05-07 02:42, with three subsequent BSSIDs returning
assoc comeback timeouts before reason-9 (STA_REQ_ASSOC_WITHOUT_AUTH)
fired. Documented in marfrit/besser:notes/phase4-2026-05-07.md.
When N=3 driver-side connection_loss decisions fire within a 60 s window
on the same vif, skip the ieee80211_connection_loss() path and trigger
the c5.2-introduced bes2600_chrdev_do_bus_reset() instead. The bus
reset removes and re-probes the chip; userspace re-associates with a
fresh chip state, dodging the AP's comeback-timer rejection cycle.
Predicted Phase 7 delta vs current baseline:
- api_connection_loss rate: unchanged (we don't address the trigger)
- conditional probability of >5 s blackhole given event: <= 30 %
- worst-case recovery: 86 s -> < 10 s
Contract pin: bes2600_chrdev_do_bus_reset(sbus_ops, sbus_priv) at
bes2600/bes_chardev.c:455, introduced by c5.2. The function is async-
returning: sbus_ops->bus_reset() schedules an SDIO rescan; the helper
waits up to 3 s for the remove() callback to clear sbus_priv, then
returns. Per-vif state is gone after this point, so the recover work
lives on bes2600_common (hw_priv) and uses the global bes2600_cdev for
the bus_reset call rather than dereferencing per-vif state.
Threshold (3 / 60 s) is well above the steady-state per-vif
connection_loss rate observed in the patch-A phase-7 rep (0.86/h under
sustained load), so a true storm is required to trip it.
Files touched:
- bes2600/bes2600.h: 3 counter fields on struct bes2600_vif, 1
work_struct on struct bes2600_common, 3 prototypes
- bes2600/sta.c: 3 helpers + storm-account hook in
bes2600_connection_loss_work + storm-init in bes2600_vif_setup +
cancel_work_sync in the hw_priv shutdown path; #include bes_chardev.h
was already pulled in by an earlier c-stack patch
- bes2600/main.c: INIT_WORK alongside other hw_priv work_structs
- bes2600/debug.c: ConnectionLossStormRecoveries seq_printf in the
per-vif status seq_file output
The cw1200/cw1260 ancestor has no equivalent; this is a clean
addition. checkpatch.pl --no-tree --strict: clean (0/0/0).
Signed-off-by: Claude (noether) <claude@reauktion.de>
99 lines
2.9 KiB
C
99 lines
2.9 KiB
C
/*
|
|
* Mac80211 driver for BES2600 device
|
|
*
|
|
* Copyright (c) 2022, Bestechnic
|
|
* Author:
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
#ifndef __BES_CHARDEV_H__
|
|
#define __BES_CHARDEV_H__
|
|
|
|
#define BES2600_FW_TYPE_WIFI_SIGNAL 0
|
|
#define BES2600_FW_TYPE_WIFI_NO_SIGNAL 1
|
|
#define BES2600_FW_TYPE_BT 2
|
|
#define BES2600_FW_TYPE_MAX_NUM 3
|
|
|
|
#define DPD_VERSION_OFFSET 0x3AF4
|
|
#define DPD_BIN_SIZE 0x3B14
|
|
#define DPD_BIN_FILE_SIZE 0x4000
|
|
#define DPD_CUR_VERSION 7
|
|
|
|
enum pend_read_op {
|
|
BES_CDEV_READ_WAKEUP_STATE = 0,
|
|
/* add new here */
|
|
|
|
BES_CDEV_READ_NUM_MAX,
|
|
};
|
|
|
|
enum wifi_wakeup_reason_code {
|
|
WAKEUP_REASON_WIFI_DEAUTH_DISASSOC = 0x1000,
|
|
WAKEUP_REASON_WIFI_BSSLOST,
|
|
/* add new here */
|
|
};
|
|
|
|
enum bt_wakeup_reason_code {
|
|
WAKEUP_REASON_BT_PLAY = 0x0100,
|
|
/* add new here */
|
|
};
|
|
|
|
enum wakeup_event {
|
|
WAKEUP_EVENT_NONE = 0,
|
|
WAKEUP_EVENT_SETTING,
|
|
WAKEUP_EVENT_WSME,
|
|
WAKEUP_EVENT_PEER_DETACH,
|
|
/* add new here */
|
|
};
|
|
|
|
/* dpd management */
|
|
u8* bes2600_chrdev_get_dpd_buffer(u32 size);
|
|
int bes2600_chrdev_update_dpd_data(void);
|
|
const u8* bes2600_chrdev_get_dpd_data(u32 *len);
|
|
void bes2600_chrdev_free_dpd_data(void);
|
|
|
|
/* get/set subs_priv instance from/to bes_chrdev module */
|
|
void bes2600_chrdev_set_sbus_priv_data(struct sbus_priv *priv, bool error);
|
|
struct sbus_priv *bes2600_chrdev_get_sbus_priv_data(void);
|
|
|
|
/* used to control device power down */
|
|
int bes2600_chrdev_check_system_close(void);
|
|
int bes2600_chrdev_do_system_close(const struct sbus_ops *sbus_ops, struct sbus_priv *priv);
|
|
int bes2600_chrdev_do_bus_reset(const struct sbus_ops *sbus_ops, struct sbus_priv *priv);
|
|
int bes2600_chrdev_trigger_bus_reset(void);
|
|
void bes2600_chrdev_wakeup_bt(void);
|
|
void bes2600_chrdev_wifi_force_close(struct bes2600_common *hw_priv, bool halt_dev);
|
|
void bes2600_chrdev_usb_remove(struct bes2600_common *hw_priv);
|
|
|
|
/* get and set internal state */
|
|
bool bes2600_chrdev_is_wifi_opened(void);
|
|
bool bes2600_chrdev_is_bt_opened(void);
|
|
int bes2600_chrdev_get_fw_type(void);
|
|
bool bes2600_chrdev_is_signal_mode(void);
|
|
void bes2600_chrdev_update_signal_mode(void);
|
|
bool bes2600_chrdev_is_bus_error(void);
|
|
|
|
/* bus probe check */
|
|
void bes2600_chrdev_start_bus_probe(void);
|
|
void bes2600_chrdev_bus_probe_notify(void);
|
|
|
|
/* set wifi wakeup state */
|
|
void bes2600_chrdev_wifi_update_wakeup_reason(u16 reason, u16 port);
|
|
void bes2600_chrdev_wakeup_by_event_set(enum wakeup_event wakeup_event);
|
|
int bes2600_chrdev_wakeup_by_event_get(void);
|
|
|
|
/* init and deinit module */
|
|
int bes2600_chrdev_init(struct sbus_ops *ops);
|
|
void bes2600_chrdev_free(void);
|
|
|
|
#ifdef BES2600_DUMP_FW_DPD_LOG
|
|
void bes2600_free_dpd_log_buffer(void);
|
|
u8* bes2600_alloc_dpd_log_buffer(u16 len);
|
|
void bes2600_get_dpd_log(char **data, size_t *len);
|
|
#endif
|
|
|
|
int bes2600_switch_bt(bool);
|
|
|
|
#endif /* __BES_CHARDEV_H__ */
|