claude-noether
fd0f5a8b71
Replace the single squashed 0001-bes2600-besser-cumulative-series.patch with 20 individual per-commit patches matching the bes2600/besser-danctnix-v3 branch in marfrit/bes2600-dkms. Also remove the duplicate 0003-arm64 entry that was a bug in pkgrel=3. Patch list: 0001 c5.1 defer scan and soften WARN on firmware reject 0002 c5.1.1 widen scan-defer backoff to 30s and decay reject_count 0003 c5.2 recover wedged firmware via mmc_hw_reset on link break 0004 c6.1 gate PM indication completion on pending request 0005 c6.2 short-circuit wake handshake when chip confirmed ACTIVE 0006 c7 self-detect when firmware does not honor PSM and skip 0007 c5.2.1 handle multi-function SDIO cards in mmc_hw_reset 0008 Patch A pre-empt AP-deauth-6 with reassoc on decrypt-fail storm 0009 Patch B bus_reset on connection-loss storm 0010 Patch F3 atomicize atomic_add() calls 0011 Patch F2 fix missing destroy_workqueue() on error in init_common 0012 Patch F1 fix concurrency UAF in bes2600_hw_scan / sched_scan 0013 Patch C v3 drop sdio_rx_work relay, IRQ→bh-direct 0014 Patch G restore SPDX identifiers + ST-Ericsson attribution 0015 Patch D atomicize ba_lock counters, drop the spinlock 0016 Patch E skip ps_state_lock when PSM-known-disabled 0017 Patch C2 replace ieee80211_rx_irqsafe with ieee80211_rx_ni 0018 Patch H bh.c hygiene cleanup (drop fossil blocks, dead stubs) 0019 besser#18 pending_record_lock SOFTIRQ-safe fix 0020 danctnix-flavor: export bus_reset helpers for bes2600_btuart Build pending (pkgrel=4 makepkg in progress on boltzmann). Signed-off-by: Claude (noether) <claude@reauktion.de>
59 lines
2.2 KiB
Diff
59 lines
2.2 KiB
Diff
From 77f966df25d24a2fb85d235bcaa6248ddc394822 Mon Sep 17 00:00:00 2001
|
|
From: Markus Fritsche <fritsche.markus@gmail.com>
|
|
Date: Thu, 7 May 2026 21:20:46 +0200
|
|
Subject: [PATCH 11/20] bes2600: fix missing destroy_workqueue() on error in
|
|
init_common
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Two error paths between create_singlethread_workqueue() (~main.c:489)
|
|
and the success-path destroy_workqueue() in unregister_common (~609)
|
|
return without cleaning up the workqueue, leaking it on probe failure:
|
|
|
|
1. bes2600_queue_stats_init() failure
|
|
2. bes2600_queue_init() failure (any of the 4 TID queues)
|
|
|
|
Both call ieee80211_free_hw(hw); return NULL — without first
|
|
destroy_workqueue(hw_priv->workqueue). Add it.
|
|
|
|
Backport of cw1200 mainline commit 7ec8a926188e ("cw1200: fix missing
|
|
destroy_workqueue() on error in cw1200_init_common", 2020-11-19),
|
|
which fixed the identical bug in the same code shape we inherited.
|
|
Reported on cw1200 by Hulk Robot.
|
|
|
|
Cherry-picked from upstream Linux:
|
|
7ec8a926188e cw1200: fix missing destroy_workqueue() on error
|
|
Author: Qinglang Miao <miaoqinglang@huawei.com>
|
|
Reported-by: Hulk Robot <hulkci@huawei.com>
|
|
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|
|
Link: https://lore.kernel.org/r/20201119070842.1011-1-miaoqinglang@huawei.com
|
|
Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
|
|
---
|
|
bes2600/main.c | 2 ++
|
|
1 file changed, 2 insertions(+)
|
|
|
|
diff --git a/drivers/staging/bes2600/main.c b/drivers/staging/bes2600/main.c
|
|
index 000329c..f9f5f3b 100644
|
|
--- a/drivers/staging/bes2600/main.c
|
|
+++ b/drivers/staging/bes2600/main.c
|
|
@@ -502,6 +502,7 @@ static struct ieee80211_hw *bes2600_init_common(size_t hw_priv_data_len)
|
|
WLAN_LINK_ID_MAX,
|
|
bes2600_skb_dtor,
|
|
hw_priv))) {
|
|
+ destroy_workqueue(hw_priv->workqueue);
|
|
ieee80211_free_hw(hw);
|
|
return NULL;
|
|
}
|
|
@@ -513,6 +514,7 @@ static struct ieee80211_hw *bes2600_init_common(size_t hw_priv_data_len)
|
|
for (; i > 0; i--)
|
|
bes2600_queue_deinit(&hw_priv->tx_queue[i - 1]);
|
|
bes2600_queue_stats_deinit(&hw_priv->tx_queue_stats);
|
|
+ destroy_workqueue(hw_priv->workqueue);
|
|
ieee80211_free_hw(hw);
|
|
return NULL;
|
|
}
|
|
--
|
|
2.54.0
|
|
|