From 39498f0d8e0fbf4fae527dcbcb96c350237eb225 Mon Sep 17 00:00:00 2001 From: Markus Fritsche Date: Tue, 5 May 2026 14:46:10 +0000 Subject: [PATCH] iter5 sweep: remove iter4 DPB census instrumentation from h264.c Removes the pre-S_EXT_CTRLS DPB census + per-entry dump that helped diagnose iter4's frame-11 EINVAL bug. With the fix landed (385dee1), the diagnostic is no longer needed in the release driver. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/h264.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/src/h264.c b/src/h264.c index 5c07818..4f30c2b 100644 --- a/src/h264.c +++ b/src/h264.c @@ -993,37 +993,6 @@ int h264_set_controls(struct request_data *driver_data, unsigned int num_controls = 0; const bool slice_based = false; /* TODO: probe via context->decode_mode */ - /* DEBUG iter4: dump DPB census + DECODE_PARAMS.flags before submission. */ - { - unsigned int dpb_valid = 0, dpb_used = 0, dpb_active = 0, dpb_lt = 0; - for (int i = 0; i < H264_DPB_SIZE; i++) { - struct v4l2_h264_dpb_entry *e = &decode.dpb[i]; - if (e->flags & V4L2_H264_DPB_ENTRY_FLAG_VALID) dpb_valid++; - if (e->flags & V4L2_H264_DPB_ENTRY_FLAG_ACTIVE) dpb_active++; - if (e->flags & V4L2_H264_DPB_ENTRY_FLAG_LONG_TERM) dpb_lt++; - } - for (int i = 0; i < H264_DPB_SIZE; i++) - if (context->dpb.entries[i].used) dpb_used++; - request_log("iter4 dbg: pre-S_EXT_CTRLS: decode.flags=0x%02x decode.frame_num=%u decode.nal_ref_idc=%u " - "decode.TopFOC=%d sps.max_refs=%u " - "dpb_valid=%u/active=%u/long=%u (ours_used=%u) sps.profile=%u sps.poc_type=%u " - "ref_l0_minus1=%u ref_l1_minus1=%u\n", - decode.flags, decode.frame_num, decode.nal_ref_idc, - decode.top_field_order_cnt, sps.max_num_ref_frames, - dpb_valid, dpb_active, dpb_lt, dpb_used, - sps.profile_idc, sps.pic_order_cnt_type, - pps.num_ref_idx_l0_default_active_minus1, - pps.num_ref_idx_l1_default_active_minus1); - for (int i = 0; i < H264_DPB_SIZE; i++) { - struct v4l2_h264_dpb_entry *e = &decode.dpb[i]; - if (!(e->flags & V4L2_H264_DPB_ENTRY_FLAG_VALID)) - continue; - request_log(" dpb[%d]: ts=%llu frame_num=%u pic_num=%u fields=0x%x flags=0x%x TopFOC=%d\n", - i, (unsigned long long)e->reference_ts, e->frame_num, e->pic_num, - e->fields, e->flags, e->top_field_order_cnt); - } - } - controls[num_controls].id = V4L2_CID_STATELESS_H264_SPS; controls[num_controls].p_h264_sps = &sps; controls[num_controls].size = sizeof(sps);