marfrit/libva-v4l2-request-fourier
1
0
Fork 1
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

iter36: remove env-gated DIAG probes (iter29/30/33/35)

Browse Source 
Cleans up the campaign's exploratory env-gated dumps now that all
bugs are fixed:
- iter29 LIBVA_HEVC_DUMP_SLICE_TAIL (h265.c) — refuted 40-byte inflation theory
- iter30 LIBVA_TS_SCALE (picture.c) — refuted timestamp magnitude theory
- iter33 LIBVA_VP8_DUMP_FRAME (vp8.c) — led to α-30 fix
- iter35 LIBVA_MPEG2_DUMP_FRAME (mpeg2.c) — confirmed MPEG-2 ctrls correct

Total: -131 lines / +7 lines (α-7 comment refresh).

Preexisting framework env knobs retained:
- LIBVA_V4L2_DUMP_OUTPUT (picture.c α-16)
- LIBVA_V4L2_DUMP_CAPTURE (surface.c)
- LIBVA_V4L2_ZERO_CAPTURE (picture.c)
- LIBVA_V4L2_REQUEST_VIDEO_PATH / MEDIA_PATH / NO_AUTODETECT (request.c)

The 3 load-bearing fixes remain unchanged:
α-25 (rkvdec image_fmt pre-seed, src/context.c)
α-29 (slice_params.short_term_ref_pic_set_size, src/h265.c)
α-30 (VP8 OUTPUT header prepend, src/picture.c)
This commit is contained in:
Claude (noether)
2026-05-14 18:12:55 +00:00
parent 48fd0288c3
commit 7db15a5685
4 changed files with 7 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mpeg2.c
-24
View File
@@ -57,9 +57,6 @@
#include "surface.h"
#include <assert.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/ioctl.h>
@@ -224,27 +221,6 @@ int mpeg2_set_controls(struct request_data *driver_data,
* surface's permanent request_fd (iter6 per-OUTPUT-slot binding;
* picture.c:284 sets surface_object->request_fd at BeginPicture).
*/
/* iter35 DIAG: dump v4l2_ctrl_mpeg2_* contents. LIBVA_MPEG2_DUMP_FRAME=1 */
if (getenv("LIBVA_MPEG2_DUMP_FRAME")) {
uint8_t *sb = (uint8_t *)&sequence;
uint8_t *pb = (uint8_t *)&pic;
uint8_t *qb = (uint8_t *)&quant;
unsigned int k;
fprintf(stderr, "mpeg2: SEQ size=%zu ", sizeof(sequence));
for (k = 0; k < sizeof(sequence); k++)
fprintf(stderr, "%02x ", sb[k]);
fprintf(stderr, "\nmpeg2: PIC size=%zu [0..32]=", sizeof(pic));
for (k = 0; k < 32 && k < sizeof(pic); k++)
fprintf(stderr, "%02x ", pb[k]);
fprintf(stderr, "\nmpeg2: PIC [32..end]=");
for (k = 32; k < sizeof(pic); k++)
fprintf(stderr, "%02x ", pb[k]);
fprintf(stderr, "\nmpeg2: QUANT size=%zu [0..16]=", sizeof(quant));
for (k = 0; k < 16; k++)
fprintf(stderr, "%02x ", qb[k]);
fprintf(stderr, "\n");
}
struct v4l2_ext_control ctrls[3] = {
{
.id = V4L2_CID_STATELESS_MPEG2_SEQUENCE,