Claude (noether) bf82a80869 sicd: v2 wire preserves argv boundaries (content = argv netstrings + terminator + payload) ...

The v2 command field was a single string the daemon SPACE-SPLIT into argv — which silently
broke sic's founding guarantee (`ssh host touch 'a b'` makes TWO files; `sic host touch 'a b'`
must make ONE). The composition of the v2 client surfaced this: every argument with a space
would be re-split.

Fix (markus chose it): v2 content is now a run of djb netstrings (the argv), terminated by the
empty netstring 0:,, then the payload — mirroring the boundary-safe v1 exec encoding. Each
argument is length-framed, so spaces, NUL, 0xFF all ride untouched; readNetstringStream already
bounds each element + its length token, so a hostile content cannot OOM here. runV2 uses the new
parseV2Content; the test frame() helper space-splits test-side only (the wire never does).

Proof: TestV2ArgvBoundaryPreserved — argv {script, "a b"} makes the script see 1 arg "a b", not
2. All existing v2 + v1 dual-read tests stay green; go vet clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-07-23 11:37:54 +02:00

..

dualread_test.go

sicd: bound the v1 length token and frame size (reviewer 925 #1 HIGH, #2 MED)

2026-07-23 10:50:50 +02:00

main.go

sicd: v2 wire preserves argv boundaries (content = argv netstrings + terminator + payload)

2026-07-23 11:37:54 +02:00

sicd_test.go

sicd: v2 wire preserves argv boundaries (content = argv netstrings + terminator + payload)

2026-07-23 11:37:54 +02:00