Claude (noether) e1f93dea7c sicd+client: explicit argc in v2 content — empty args representable (reviewer 964 #1) ...

Ship-blocker #1: the empty-netstring terminator collided with a legit empty "" argument —
parseV2Content broke on the first len(ns)==0, so echo A "" B ran as echo A and B bled into
child stdin (wrong command executed, not rejected). Replaced the terminator with an explicit
argc prefix: content = netstring(argc) + argv netstrings + payload; the daemon reads EXACTLY
argc elements, so "" is a normal arg. Fixes the collision AND the element-count bound in one.
Daemon parseV2Content, client v2Frame, both test helpers, and the reference builder all updated.
Proof: TestV2EmptyArgPreserved (echo A "" B -> "A  B") + TestV2FrameEmptyArgRepresentable.
All v2/v1 tests green, vet clean. Daemon now clears reviewer 964 #1/#2/#3 — deployable.

2026-07-23 11:50:35 +02:00

..

dualread_test.go

sicd: bound the v1 length token and frame size (reviewer 925 #1 HIGH, #2 MED)

2026-07-23 10:50:50 +02:00

main.go

sicd+client: explicit argc in v2 content — empty args representable (reviewer 964 #1)

2026-07-23 11:50:35 +02:00

sicd_test.go

sicd+client: explicit argc in v2 content — empty args representable (reviewer 964 #1)

2026-07-23 11:50:35 +02:00