895f57c63a
Adds /dev/daedalus-v4l2 misc chardev to the kernel module. The
chardev is the IPC channel for the future userspace decoder
daemon: kernel enqueues REQ_* messages, daemon read()s them,
processes, write()s RESP_* back.
Wire protocol (pre-1.0, header in include/daedalus_v4l2_proto.h):
- struct daedalus_msg_hdr: magic (D04V) + version + type +
cookie + payload_len + reserved
- Request/response separated by high bit of type field
- Max 64 KiB payload per message
- Cookie correlates request with matching response
Kernel implementation (kernel/daedalus_v4l2_chardev.{c,h}):
- Single-instance chardev (-EBUSY on second open)
- In-kernel FIFO bounded at 64 messages
- Blocking + non-blocking read; poll() with EPOLLIN on queued
- write() parses + validates header, logs response at pr_debug
- Bad magic → -EBADMSG, bad version → -EPROTO, oversize → -EMSGSIZE
- All error paths free resources
Phase 8.2 test trigger via debugfs:
- /sys/kernel/debug/daedalus_v4l2/test_ping — any byte
enqueues a PING with a fixed 24-byte payload. Removed in
Phase 8.4 when real REQ_DECODE from V4L2 path takes over.
Userspace verification tool (tools/test_chardev_pingpong.c):
- Real C program, proper error reporting via strerror
- Validates the 6-step round-trip: open → empty-queue EAGAIN →
trigger ping → read PING → verify all fields → write PONG → close
- Builds with -Wall -Wextra clean
Verification on hertz (Pi 5, 6.12.75+rpt-rpi-2712):
$ sudo insmod daedalus_v4l2.ko
$ sudo tools/test_chardev_pingpong
opening /dev/daedalus-v4l2...
non-blocking read on empty queue: EAGAIN ✓
injected PING via debugfs ✓
read PING: magic ✓ version ✓ type=PING ✓ cookie=0x1234 ✓ payload=24 bytes
payload: "DAEDALUS-V4L2-PING-PL"
wrote PONG (cookie=0x1234) ✓
ALL TESTS PASSED.
$ sudo rmmod daedalus_v4l2 # clean
Per correctness-before-speed: full kerneldoc on structs, 8-tab
kernel style, SPDX headers, proper error paths, real test
program (not "I ran it once"), failure-mode coverage documented.
Phase 8.3 next: userspace daemon with dlopen'd FFmpeg parse path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
388 lines
10 KiB
C
388 lines
10 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* daedalus-v4l2 — kernel ↔ daemon chardev bridge.
|
|
*
|
|
* Exposes /dev/daedalus-v4l2 (a misc-class character device)
|
|
* for the userspace daemon to attach to. Single-instance:
|
|
* only one open file at a time. Blocking read() pulls the next
|
|
* request from a kernel-side FIFO; write() submits a response.
|
|
*
|
|
* Phase 8.2 scope: PING request handling — the daemon writes a
|
|
* PONG response to a PING request that arrives via read(). In
|
|
* Phase 8.2 the kernel injects test PING requests itself via a
|
|
* debugfs trigger (no V4L2 ioctl flow yet); Phase 8.4 wires
|
|
* real DECODE requests from the V4L2 path.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/miscdevice.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/wait.h>
|
|
#include <linux/list.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/uaccess.h>
|
|
#include <linux/poll.h>
|
|
#include <linux/debugfs.h>
|
|
|
|
#include "daedalus_v4l2_proto.h"
|
|
#include "daedalus_v4l2_chardev.h"
|
|
|
|
#define DAEDALUS_CHARDEV_NAME "daedalus-v4l2"
|
|
|
|
/* Cap the number of pending requests so a stuck daemon can't OOM us. */
|
|
#define DAEDALUS_QUEUE_MAX 64
|
|
|
|
/**
|
|
* struct daedalus_chardev_msg - in-kernel queued message
|
|
* @list: queue linkage
|
|
* @hdr: wire header
|
|
* @payload: payload bytes; size = hdr.payload_len
|
|
*/
|
|
struct daedalus_chardev_msg {
|
|
struct list_head list;
|
|
struct daedalus_msg_hdr hdr;
|
|
u8 *payload;
|
|
};
|
|
|
|
/**
|
|
* struct daedalus_chardev - per-singleton chardev state
|
|
* @misc: misc-class device registration
|
|
* @open_lock: serialises open()/release()
|
|
* @opened: non-zero when the chardev is currently open
|
|
* @req_lock: protects @req_queue / @req_count
|
|
* @req_queue: list of pending REQ_* messages waiting for daemon read()
|
|
* @req_count: current number of queued requests
|
|
* @req_wait: read() blocks here until a request arrives
|
|
*/
|
|
struct daedalus_chardev {
|
|
struct miscdevice misc;
|
|
struct mutex open_lock;
|
|
int opened;
|
|
struct mutex req_lock;
|
|
struct list_head req_queue;
|
|
int req_count;
|
|
wait_queue_head_t req_wait;
|
|
struct dentry *debugfs_dir;
|
|
};
|
|
|
|
static struct daedalus_chardev *g_chardev;
|
|
|
|
/* -- internal helpers ------------------------------------------------ */
|
|
|
|
static struct daedalus_chardev_msg *
|
|
daedalus_chardev_dequeue_locked(struct daedalus_chardev *dev)
|
|
{
|
|
struct daedalus_chardev_msg *msg;
|
|
|
|
if (list_empty(&dev->req_queue))
|
|
return NULL;
|
|
msg = list_first_entry(&dev->req_queue,
|
|
struct daedalus_chardev_msg, list);
|
|
list_del(&msg->list);
|
|
dev->req_count--;
|
|
return msg;
|
|
}
|
|
|
|
static void daedalus_chardev_msg_free(struct daedalus_chardev_msg *msg)
|
|
{
|
|
if (!msg)
|
|
return;
|
|
kfree(msg->payload);
|
|
kfree(msg);
|
|
}
|
|
|
|
int daedalus_chardev_enqueue_req(u32 type, u32 cookie,
|
|
const void *payload, size_t payload_len)
|
|
{
|
|
struct daedalus_chardev *dev = g_chardev;
|
|
struct daedalus_chardev_msg *msg;
|
|
|
|
if (!dev)
|
|
return -ENODEV;
|
|
if (payload_len > DAEDALUS_PROTO_MAX_PAYLOAD)
|
|
return -EMSGSIZE;
|
|
if (type & 0x80000000u) /* responses don't get queued here */
|
|
return -EINVAL;
|
|
|
|
msg = kzalloc(sizeof(*msg), GFP_KERNEL);
|
|
if (!msg)
|
|
return -ENOMEM;
|
|
if (payload_len) {
|
|
msg->payload = kmemdup(payload, payload_len, GFP_KERNEL);
|
|
if (!msg->payload) {
|
|
kfree(msg);
|
|
return -ENOMEM;
|
|
}
|
|
}
|
|
msg->hdr.magic = DAEDALUS_PROTO_MAGIC;
|
|
msg->hdr.version = DAEDALUS_PROTO_VERSION;
|
|
msg->hdr.type = type;
|
|
msg->hdr.cookie = cookie;
|
|
msg->hdr.payload_len = (u32) payload_len;
|
|
msg->hdr.reserved = 0;
|
|
|
|
mutex_lock(&dev->req_lock);
|
|
if (dev->req_count >= DAEDALUS_QUEUE_MAX) {
|
|
mutex_unlock(&dev->req_lock);
|
|
daedalus_chardev_msg_free(msg);
|
|
return -ENOSPC;
|
|
}
|
|
list_add_tail(&msg->list, &dev->req_queue);
|
|
dev->req_count++;
|
|
mutex_unlock(&dev->req_lock);
|
|
wake_up_interruptible(&dev->req_wait);
|
|
return 0;
|
|
}
|
|
|
|
/* -- file operations ------------------------------------------------- */
|
|
|
|
static int daedalus_chardev_open(struct inode *inode, struct file *file)
|
|
{
|
|
struct daedalus_chardev *dev = g_chardev;
|
|
|
|
mutex_lock(&dev->open_lock);
|
|
if (dev->opened) {
|
|
mutex_unlock(&dev->open_lock);
|
|
return -EBUSY;
|
|
}
|
|
dev->opened = 1;
|
|
mutex_unlock(&dev->open_lock);
|
|
file->private_data = dev;
|
|
return 0;
|
|
}
|
|
|
|
static int daedalus_chardev_release(struct inode *inode, struct file *file)
|
|
{
|
|
struct daedalus_chardev *dev = file->private_data;
|
|
struct daedalus_chardev_msg *msg;
|
|
|
|
mutex_lock(&dev->req_lock);
|
|
while ((msg = daedalus_chardev_dequeue_locked(dev)) != NULL) {
|
|
mutex_unlock(&dev->req_lock);
|
|
daedalus_chardev_msg_free(msg);
|
|
mutex_lock(&dev->req_lock);
|
|
}
|
|
mutex_unlock(&dev->req_lock);
|
|
|
|
mutex_lock(&dev->open_lock);
|
|
dev->opened = 0;
|
|
mutex_unlock(&dev->open_lock);
|
|
return 0;
|
|
}
|
|
|
|
static ssize_t daedalus_chardev_read(struct file *file, char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
struct daedalus_chardev *dev = file->private_data;
|
|
struct daedalus_chardev_msg *msg;
|
|
size_t total;
|
|
int ret;
|
|
|
|
if (count < sizeof(struct daedalus_msg_hdr))
|
|
return -EINVAL;
|
|
|
|
for (;;) {
|
|
mutex_lock(&dev->req_lock);
|
|
msg = daedalus_chardev_dequeue_locked(dev);
|
|
mutex_unlock(&dev->req_lock);
|
|
if (msg)
|
|
break;
|
|
if (file->f_flags & O_NONBLOCK)
|
|
return -EAGAIN;
|
|
ret = wait_event_interruptible(dev->req_wait,
|
|
dev->req_count > 0);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
total = sizeof(msg->hdr) + msg->hdr.payload_len;
|
|
if (count < total) {
|
|
/*
|
|
* Requeue so the caller can retry with a bigger buffer.
|
|
* Re-enqueue at HEAD to preserve FIFO order.
|
|
*/
|
|
mutex_lock(&dev->req_lock);
|
|
list_add(&msg->list, &dev->req_queue);
|
|
dev->req_count++;
|
|
mutex_unlock(&dev->req_lock);
|
|
return -EMSGSIZE;
|
|
}
|
|
|
|
if (copy_to_user(buf, &msg->hdr, sizeof(msg->hdr))) {
|
|
daedalus_chardev_msg_free(msg);
|
|
return -EFAULT;
|
|
}
|
|
if (msg->hdr.payload_len &&
|
|
copy_to_user(buf + sizeof(msg->hdr), msg->payload,
|
|
msg->hdr.payload_len)) {
|
|
daedalus_chardev_msg_free(msg);
|
|
return -EFAULT;
|
|
}
|
|
|
|
daedalus_chardev_msg_free(msg);
|
|
return total;
|
|
}
|
|
|
|
static ssize_t daedalus_chardev_write(struct file *file,
|
|
const char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
struct daedalus_msg_hdr hdr;
|
|
u8 *payload = NULL;
|
|
size_t expected;
|
|
|
|
if (count < sizeof(hdr))
|
|
return -EINVAL;
|
|
if (copy_from_user(&hdr, buf, sizeof(hdr)))
|
|
return -EFAULT;
|
|
if (hdr.magic != DAEDALUS_PROTO_MAGIC)
|
|
return -EBADMSG;
|
|
if (hdr.version != DAEDALUS_PROTO_VERSION)
|
|
return -EPROTO;
|
|
if (hdr.payload_len > DAEDALUS_PROTO_MAX_PAYLOAD)
|
|
return -EMSGSIZE;
|
|
expected = sizeof(hdr) + hdr.payload_len;
|
|
if (count < expected)
|
|
return -EINVAL;
|
|
|
|
if (hdr.payload_len) {
|
|
payload = kmalloc(hdr.payload_len, GFP_KERNEL);
|
|
if (!payload)
|
|
return -ENOMEM;
|
|
if (copy_from_user(payload, buf + sizeof(hdr),
|
|
hdr.payload_len)) {
|
|
kfree(payload);
|
|
return -EFAULT;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Phase 8.2 handling: log the response type. Phase 8.4
|
|
* will wire RESP_FRAME etc. to the V4L2 buffer queue.
|
|
*/
|
|
pr_debug("daedalus_v4l2: chardev got response type=0x%08x cookie=%u plen=%u\n",
|
|
hdr.type, hdr.cookie, hdr.payload_len);
|
|
|
|
kfree(payload);
|
|
return expected;
|
|
}
|
|
|
|
static __poll_t daedalus_chardev_poll(struct file *file,
|
|
struct poll_table_struct *wait)
|
|
{
|
|
struct daedalus_chardev *dev = file->private_data;
|
|
__poll_t mask = EPOLLOUT | EPOLLWRNORM;
|
|
|
|
poll_wait(file, &dev->req_wait, wait);
|
|
if (READ_ONCE(dev->req_count) > 0)
|
|
mask |= EPOLLIN | EPOLLRDNORM;
|
|
return mask;
|
|
}
|
|
|
|
/*
|
|
* .llseek intentionally unset. The chardev is a streaming
|
|
* request/response channel; no positional semantics. Recent
|
|
* kernels removed `no_llseek`; leaving the slot NULL gets the
|
|
* generic "no-op or -ESPIPE" behaviour the v6.12+ vfs picks.
|
|
*/
|
|
static const struct file_operations daedalus_chardev_fops = {
|
|
.owner = THIS_MODULE,
|
|
.open = daedalus_chardev_open,
|
|
.release = daedalus_chardev_release,
|
|
.read = daedalus_chardev_read,
|
|
.write = daedalus_chardev_write,
|
|
.poll = daedalus_chardev_poll,
|
|
};
|
|
|
|
/* -- debugfs test trigger (Phase 8.2 only) --------------------------- */
|
|
/*
|
|
* Writing any non-zero byte stream to
|
|
* /sys/kernel/debug/daedalus_v4l2/test_ping enqueues a PING
|
|
* request with a fixed 24-byte payload "DAEDALUS-V4L2-PING-PL\0\0\0".
|
|
* The userspace test daemon (tools/test_chardev_pingpong.c)
|
|
* then reads it back, sends PONG, and the kernel logs the
|
|
* round-trip at pr_debug level.
|
|
*
|
|
* Phase 8.4 replaces this with real REQ_DECODE injection from
|
|
* the V4L2 buffer-submit path; the debugfs entry can be removed
|
|
* then.
|
|
*/
|
|
static ssize_t daedalus_test_ping_write(struct file *file,
|
|
const char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
static const char payload[24] = "DAEDALUS-V4L2-PING-PL";
|
|
int ret;
|
|
|
|
ret = daedalus_chardev_enqueue_req(DAEDALUS_MSG_PING, 0x1234u,
|
|
payload, sizeof(payload));
|
|
if (ret)
|
|
return ret;
|
|
return count;
|
|
}
|
|
|
|
static const struct file_operations daedalus_test_ping_fops = {
|
|
.owner = THIS_MODULE,
|
|
.write = daedalus_test_ping_write,
|
|
};
|
|
|
|
/* -- registration ---------------------------------------------------- */
|
|
|
|
int daedalus_chardev_init(void)
|
|
{
|
|
struct daedalus_chardev *dev;
|
|
int ret;
|
|
|
|
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
|
|
if (!dev)
|
|
return -ENOMEM;
|
|
mutex_init(&dev->open_lock);
|
|
mutex_init(&dev->req_lock);
|
|
INIT_LIST_HEAD(&dev->req_queue);
|
|
init_waitqueue_head(&dev->req_wait);
|
|
|
|
dev->misc.minor = MISC_DYNAMIC_MINOR;
|
|
dev->misc.name = DAEDALUS_CHARDEV_NAME;
|
|
dev->misc.fops = &daedalus_chardev_fops;
|
|
dev->misc.mode = 0660; /* root:video, like /dev/videoNN */
|
|
|
|
ret = misc_register(&dev->misc);
|
|
if (ret) {
|
|
kfree(dev);
|
|
return ret;
|
|
}
|
|
|
|
dev->debugfs_dir = debugfs_create_dir("daedalus_v4l2", NULL);
|
|
if (!IS_ERR(dev->debugfs_dir))
|
|
debugfs_create_file("test_ping", 0200, dev->debugfs_dir,
|
|
NULL, &daedalus_test_ping_fops);
|
|
|
|
g_chardev = dev;
|
|
pr_info("daedalus_v4l2: /dev/%s registered\n", DAEDALUS_CHARDEV_NAME);
|
|
return 0;
|
|
}
|
|
|
|
void daedalus_chardev_exit(void)
|
|
{
|
|
struct daedalus_chardev *dev = g_chardev;
|
|
struct daedalus_chardev_msg *msg;
|
|
|
|
if (!dev)
|
|
return;
|
|
debugfs_remove_recursive(dev->debugfs_dir);
|
|
misc_deregister(&dev->misc);
|
|
|
|
while ((msg = list_first_entry_or_null(&dev->req_queue,
|
|
struct daedalus_chardev_msg,
|
|
list)) != NULL) {
|
|
list_del(&msg->list);
|
|
daedalus_chardev_msg_free(msg);
|
|
}
|
|
mutex_destroy(&dev->req_lock);
|
|
mutex_destroy(&dev->open_lock);
|
|
kfree(dev);
|
|
g_chardev = NULL;
|
|
}
|