Sonnet round 2 review ACCEPTED 0007 v2 + 4 of 5 amendment areas.
Q3 found one new issue introduced by amendments: U-Boot extlinux menu
selection requires physical keyboard/HDMI presence — not workable for
SSH-only operators relying on serial console.
Fix (single prose addition to step 1.6): if remote-only operator
relying on serial (0.4b), temporarily set DEFAULT arch_devices_lockdep
for this test boot. Restore DEFAULT arch_devices before any non-test
reboot. If ramoops-only (0.4a, no serial), DEFAULT override MANDATORY.
Q1 (0007 v2 source), Q2 (5 amendments), Q4 (recovery sufficiency) all
ACCEPTed. With this Q3 prose fix applied, Phase 5 review complete.
Pending user sign-off + serial cable confirmation before pre-flight.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Amendments per Sonnet architect review round 1:
- A1: 0007 v2 rewritten — 7 per-codec run() insertion points,
matches hantro pattern (after preamble metadata copy, before HW kick).
Old v1 (in rkvdec_device_run) REJECTED — wrong structural placement.
- A2: panthor ww_mutex/dma_resv contention added as primary hypothesis H1.
Smoke test 1.9/2.x extended to exercise GPU compositor path.
- A3: CONFIG_LOCALVERSION=-lockdep so lockdep kernel uname differs from
vanilla — prevents modules_install overwriting working tree.
- A4: pstore/serial gate is now HARD (one-of required); pre-flight aborts
if neither serial nor ramoops is functional.
- A5: PROVE_RCU removed from initial config — boot latency risk pushes
past watchdog before lockdep prints. Add back only if first run clean.
0007-v2 patch attached: 8 hunks across rkvdec-{h264,hevc,vdpu381-h264,
vdpu381-hevc,vdpu383-h264,vdpu383-hevc,vp9}.c + rkvdec.c queue_init flag.
25 lines insertions.
Pending Phase 5 round 2 delta-review of v2 source + amended plan before
any execution.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Markus Fritsche