marfrit/aish
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TC #91 — Phase 9 walk-up R1 fix: HOME-prefix false positive #91

New Issue
Closed
opened 2026-05-16 23:55:09 +00:00 by claude-noether · 1 comment
claude-noether commented 2026-05-16 23:55:09 +00:00
Collaborator
Copy Link
Copy Source

Scenario / Expected

When HOME=/home/user and cwd=/home/user2/foo, walk-up MUST return nil. The proper-prefix check (dir == home OR dir startswith home..'/') prevents the bare-byte-prefix match that would let user2's tree be searched as if it were user's.

## Scenario / Expected When HOME=/home/user and cwd=/home/user2/foo, walk-up MUST return nil. The proper-prefix check (dir == home OR dir startswith home..'/') prevents the bare-byte-prefix match that would let user2's tree be searched as if it were user's.
claude-noether added the test-case label 2026-05-16 23:55:09 +00:00
claude-noether commented 2026-05-16 23:55:59 +00:00
Author
Collaborator
Copy Link
Copy Source

Verified PASS via autonomous test driver at commit df59ee2 (Phase 9 implement-complete).

R1 invariant holds. With HOME=$DIR/userX and cwd=$DIR/userX2/proj (sibling, not child), the proper-prefix check (dir == home OR dir startswith home..'/') correctly rejects — no overlay loaded. The bare-byte-prefix bug Sonnet caught would have walked into userX2 since /tmp/.../userX is a prefix of /tmp/.../userX2.

Closed by Phase 9 verify.

Verified PASS via autonomous test driver at commit `df59ee2` (Phase 9 implement-complete). R1 invariant holds. With HOME=$DIR/userX and cwd=$DIR/userX2/proj (sibling, not child), the proper-prefix check (`dir == home OR dir startswith home..'/'`) correctly rejects — no overlay loaded. The bare-byte-prefix bug Sonnet caught would have walked into userX2 since /tmp/.../userX is a prefix of /tmp/.../userX2. Closed by Phase 9 verify.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Behavior diverges from documented or expected operation.
 feature request
User-facing capability that aish does not yet have.
 recommendation
Concrete suggestion (config, deployment, integration) outside the strict feature/bug split.
 security
Affects credential/key/PII handling, sandboxing, or trust boundaries.
 test-case
User-runnable test scenario; comment to confirm pass or add `bug` tag on fail
No Label test-case
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude-noether (Claude (noether)) marfrit (Markus Fritsche)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marfrit/aish#91
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?