marfrit/libva-v4l2-request-fourier
1
0
Fork 1
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

iter5 sweep: remove iter1 ENTER traces (13 call sites across 4 files)

Browse Source 
Removes the iter1 patch-0014 ENTER traces from buffer.c, image.c,
picture.c, surface.c. These were diagnostic-only entry-point logs
added during iter1's "where does Firefox RDD crash?" investigation.
With the iter1+iter2+iter3+iter4 fixes landed, the entry-point
traces are pure noise.

If a future investigation needs entry-point coverage, strace -e trace
on the libva consumer process gives equivalent visibility without
modifying the driver.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Markus Fritsche
2026-05-05 14:47:25 +00:00
parent 39498f0d8e
commit 951233a12e
4 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/buffer.c
-6
View File
@@ -55,8 +55,6 @@ VAStatus RequestCreateBuffer(VADriverContextP context, VAContextID context_id,
VAStatus status;
VABufferID id;
request_log("ENTER RequestCreateBuffer(ctx=%u, type=%u, size=%u, count=%u)\n",
context_id, (unsigned)type, size, count);
switch (type) {
case VAPictureParameterBufferType:
@@ -112,7 +110,6 @@ complete:
VAStatus RequestDestroyBuffer(VADriverContextP context, VABufferID buffer_id)
{
request_log("ENTER RequestDestroyBuffer(buf=%u)\n", buffer_id);
struct request_data *driver_data = context->pDriverData;
struct object_buffer *buffer_object;
@@ -133,7 +130,6 @@ VAStatus RequestDestroyBuffer(VADriverContextP context, VABufferID buffer_id)
VAStatus RequestMapBuffer(VADriverContextP context, VABufferID buffer_id,
void **data_map)
{
request_log("ENTER RequestMapBuffer(buf=%u)\n", buffer_id);
struct request_data *driver_data = context->pDriverData;
struct object_buffer *buffer_object;
@@ -150,7 +146,6 @@ VAStatus RequestMapBuffer(VADriverContextP context, VABufferID buffer_id,
VAStatus RequestUnmapBuffer(VADriverContextP context, VABufferID buffer_id)
{
request_log("ENTER RequestUnmapBuffer(buf=%u)\n", buffer_id);
struct request_data *driver_data = context->pDriverData;
struct object_buffer *buffer_object;
@@ -254,7 +249,6 @@ VAStatus RequestAcquireBufferHandle(VADriverContextP context,
VAStatus RequestReleaseBufferHandle(VADriverContextP context,
VABufferID buffer_id)
{
request_log("ENTER RequestReleaseBufferHandle(buf=%u)\n", buffer_id);
struct request_data *driver_data = context->pDriverData;
struct object_buffer *buffer_object;
src/image.c
-5
View File
@@ -125,7 +125,6 @@ VAStatus RequestCreateImage(VADriverContextP context, VAImageFormat *format,
VAStatus RequestDestroyImage(VADriverContextP context, VAImageID image_id)
{
request_log("ENTER RequestDestroyImage(img=%u)\n", image_id);
struct request_data *driver_data = context->pDriverData;
struct object_image *image_object;
@@ -186,7 +185,6 @@ VAStatus RequestDeriveImage(VADriverContextP context, VASurfaceID surface_id,
VAImageFormat format;
VAStatus status;
request_log("ENTER RequestDeriveImage(surf=%u)\n", surface_id);
surface_object = SURFACE(driver_data, surface_id);
if (surface_object == NULL)
@@ -237,7 +235,6 @@ VAStatus RequestDeriveImage(VADriverContextP context, VASurfaceID surface_id,
VAStatus RequestQueryImageFormats(VADriverContextP context,
VAImageFormat *formats, int *formats_count)
{
request_log("ENTER RequestQueryImageFormats\n");
/*
* Populate the VAImageFormat fully per VAAPI spec for NV12 —
@@ -277,8 +274,6 @@ VAStatus RequestGetImage(VADriverContextP context, VASurfaceID surface_id,
struct object_image *image_object;
VAImage *image;
request_log("ENTER RequestGetImage(surf=%u, x=%d y=%d w=%u h=%u, img=%u)\n",
surface_id, x, y, width, height, image_id);
surface_object = SURFACE(driver_data, surface_id);
if (surface_object == NULL)
src/picture.c
-2
View File
@@ -221,8 +221,6 @@ VAStatus RequestBeginPicture(VADriverContextP context, VAContextID context_id,
struct request_pool_slot *slot;
int slot_index;
request_log("ENTER RequestBeginPicture(ctx=%u, surf=%u)\n",
context_id, surface_id);
context_object = CONTEXT(driver_data, context_id);
if (context_object == NULL)
src/surface.c
-4
View File
@@ -411,7 +411,6 @@ VAStatus RequestDestroySurfaces(VADriverContextP context,
VAStatus RequestSyncSurface(VADriverContextP context, VASurfaceID surface_id)
{
request_log("ENTER RequestSyncSurface(surf=%u)\n", surface_id);
struct request_data *driver_data = context->pDriverData;
struct object_surface *surface_object;
@@ -575,8 +574,6 @@ VAStatus RequestQuerySurfaceAttributes(VADriverContextP context,
VASurfaceAttrib *attributes,
unsigned int *attributes_count)
{
request_log("ENTER RequestQuerySurfaceAttributes(config=%u, attrs_buf=%p)\n",
config, (void *)attributes);
struct request_data *driver_data = context->pDriverData;
VASurfaceAttrib *attributes_list;
@@ -656,7 +653,6 @@ VAStatus RequestQuerySurfaceStatus(VADriverContextP context,
struct request_data *driver_data = context->pDriverData;
struct object_surface *surface_object;
request_log("ENTER RequestQuerySurfaceStatus(surf=%u)\n", surface_id);
surface_object = SURFACE(driver_data, surface_id);
if (surface_object == NULL)