firefox-fourier 0003: proper V4L2REQUEST type acceptance patch (closes #60) #63

Merged
marfrit merged 1 commits from firefox-0003-v4l2request-proper-2026-05-21 into main 2026-05-21 05:10:27 +00:00
Owner

Replaces 0003 with a regenerated version that ACTUALLY APPLIES — generated via:

  1. apt-get source firefox 150.0.3-1+rpt1 on bohr (debian trixie aarch64)
  2. Apply marfrit 0001, 0002, original 0003, 0004, 0005 via patch -p1
  3. Apply the V4L2REQUEST acceptance seds from build-script v8:
    • cfg->device_type == AV_HWDEVICE_TYPE_DRM → also OR (int)cfg->device_type == 13 || (int)cfg->device_type == 14
    • AV_HWDEVICE_TYPE_DRM, drmDevice,(enum AVHWDeviceType)13, drmDevice,
  4. diff -u PRE POST on FFmpegVideoDecoder.{cpp,h} → consolidated 0003

Vs prior (malformed) attempt in #61: this one was machine-generated from real source so hunk offsets are correct.

Replaces the in-source-sed hack in firefox-rpios-build-v7/v8 scripts (drop that after this merges).

Diff stat: +23/-22 lines on the patch file itself (functional change is small once you ignore comment-text edits in the patch description).

Replaces 0003 with a regenerated version that ACTUALLY APPLIES — generated via: 1. apt-get source firefox 150.0.3-1+rpt1 on bohr (debian trixie aarch64) 2. Apply marfrit 0001, 0002, original 0003, 0004, 0005 via `patch -p1` 3. Apply the V4L2REQUEST acceptance seds from build-script v8: - `cfg->device_type == AV_HWDEVICE_TYPE_DRM` → also OR `(int)cfg->device_type == 13 || (int)cfg->device_type == 14` - `AV_HWDEVICE_TYPE_DRM, drmDevice,` → `(enum AVHWDeviceType)13, drmDevice,` 4. `diff -u PRE POST` on FFmpegVideoDecoder.{cpp,h} → consolidated 0003 Vs prior (malformed) attempt in #61: this one was machine-generated from real source so hunk offsets are correct. Replaces the in-source-sed hack in firefox-rpios-build-v7/v8 scripts (drop that after this merges). Diff stat: +23/-22 lines on the patch file itself (functional change is small once you ignore comment-text edits in the patch description).
marfrit added 1 commit 2026-05-21 04:59:38 +00:00
Closes #60.

Resolves the malformed-patch issue from #61 (since reverted in #62)
by regenerating the 0003 patch via actual application against firefox
150.0.3 Pi-OS source.

Functional change vs prior 0003: walking hw_configs accepts
AV_HWDEVICE_TYPE_DRM (legacy) OR integer device_type values 13/14
(AV_HWDEVICE_TYPE_V4L2REQUEST in Kwibos no-AMF / upstream-AMF trees).
CreateV4L2RequestDeviceContext passes integer 13 (Kwibos value) cast
to enum AVHWDeviceType for the av_hwdevice_ctx_create call.

Tested: applied cleanly via patch -p1 against firefox-150.0.3 source
post-Pi-OS-quilt-patches. Test build follow-up in firefox-rpios EC2
script (drops the in-source sed hack from v7-v8).
marfrit merged commit 2cd3acd680 into main 2026-05-21 05:10:27 +00:00
marfrit deleted branch firefox-0003-v4l2request-proper-2026-05-21 2026-05-21 05:10:28 +00:00
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marfrit/marfrit-packages#63