2a449632b9
Wires the Phase 8.3 FFmpeg loader through the Phase 8.2 chardev
bridge: kernel injects REQ_DECODE carrying a raw VP9 access unit,
daemon hands the bitstream to libavcodec via dlopen, sends
RESP_FRAME back with a content-dependent FNV-1a digest of the
decoded YUV planes. Pure CPU decode for now — Phase 8.5 swaps in
dmabuf + QPU dispatch.
Protocol (include/daedalus_v4l2_proto.h):
- New REQ_DECODE (kernel→daemon) and RESP_FRAME (daemon→kernel)
message types, with fixed-size payload structs.
- New DAEDALUS_CODEC_VP9/AV1/H264 enum (wire-stable so 8.6's
AV1+H.264 work doesn't move existing values).
- New DAEDALUS_DECODE_* status enum (OK / NO_FRAME / ERR_OPEN /
ERR_SEND / ERR_RECV / ERR_CODEC).
- Converted the prior `enum daedalus_msg_type` to #defines —
high-bit values exceed INT_MAX and tripped -Wpedantic on
userspace; kernel uABI headers use the same idiom.
Kernel (kernel/daedalus_v4l2_chardev.c):
- New debugfs entry /sys/kernel/debug/daedalus_v4l2/test_decode:
writing raw bitstream bytes wraps them in a REQ_DECODE
(codec=VP9 for Phase 8.4) and enqueues with an
auto-incrementing cookie.
- daedalus_chardev_write learned RESP_FRAME: parses the payload
and emits a single pr_info line with decode metadata. Keeps
existing PONG handling on the default arm.
Daemon (daemon/src/...):
- chardev_client.{c,h} — opens /dev/daedalus-v4l2, blocking read
loop, single-buffer write() responses (kernel chardev has only
.write, not .write_iter, so writev lands as -EINVAL —
discovered the hard way during first run).
- decoder.{c,h} — lazily-opened AVCodecContext per codec, shared
AVPacket/AVFrame pair, descriptor-driven plane walker
(av_pix_fmt_desc_get) so the same hash path covers YUV420P,
YUV422P, YUV444P, GBRP and other 8-bit planar layouts.
Generalised after first run decoded testsrc as GBRP (71)
rather than the assumed YUV420P.
- `daemon` command in main.c opens the chardev and runs the loop
until SIGINT/SIGTERM. Cookie correlation handled end-to-end.
- ffmpeg_loader gained av_pix_fmt_desc_get (23 symbols total).
Build:
- CMakeLists adds chardev_client.c + decoder.c; explicit
-I../include for the shared protocol header.
- Still -Wall -Wextra -Wpedantic clean.
Verification on hertz (Pi 5, 6.12.75+rpt-rpi-2712):
$ ffmpeg ... -pix_fmt yuv420p -c:v libvpx-vp9 -frames:v 1 \
-y /tmp/vp9_test.ivf
$ python3 ... strip IVF framing → vp9_keyframe.bin (3268 B)
$ sudo insmod kernel/daedalus_v4l2.ko
$ daedalus_v4l2_daemon -v daemon &
$ sudo dd if=vp9_keyframe.bin \
of=/sys/kernel/debug/daedalus_v4l2/test_decode
daemon: REQ_DECODE cookie=2 → decoded yuv420p 320x240
fnv1a=0x6ef10d71 luma=76800 chroma=38400
kernel: RESP_FRAME cookie=2 status=0 320x240 pixfmt=0
fnv1a=0x6ef10d71 ← matches daemon ✓
Hash properties verified:
cookie=2 testsrc 3268 B → 0x6ef10d71 (first decode)
cookie=3 red 44 B → 0x7f6e5dc5 (content-dependent ✓)
cookie=4 testsrc 3268 B → 0x6ef10d71 (deterministic ✓)
cookie=5 64 B random → status=101 (ERR_SEND, daemon alive)
Daemon survives bad input (FFmpeg "Invalid sync code" wrapped
into structured ERR_SEND response). Clean SIGTERM shutdown,
clean rmmod.
Phase 8.4 acceptance criteria met:
- ✓ end-to-end kernel→daemon→FFmpeg→kernel round-trip
- ✓ cookie correlation per request/response pair
- ✓ content-dependent + deterministic digest
- ✓ structured error responses (no daemon crash on bad input)
- ✓ clean teardown (SIGTERM + rmmod)
- ✓ builds clean on both kernel kbuild and daemon CMake
Per correctness-before-speed:
- Real chardev I/O (no shortcuts, no select-loop hacks)
- Real FFmpeg AVCodecContext lifecycle (lazily opened, properly
freed on cleanup)
- Descriptor-driven plane walk (generalises across pix_fmts)
- Structured error path (not just log-and-continue)
- All resource paths cleaned up on every error branch
- Documented why FNV-1a digest, why write() not writev(), why
pix_desc walk in docs/phase_8_4_closure.md
Phase 8.5 next: V4L2 m2m queue submits REQ_DECODE from
vidioc_qbuf; dmabuf carries actual pixel data so the chardev's
64 KiB cap doesn't gate frame size; begin substituting
daedalus_dispatch_* into the daemon's decode path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
474 lines
12 KiB
C
474 lines
12 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* daedalus-v4l2 — kernel ↔ daemon chardev bridge.
|
|
*
|
|
* Exposes /dev/daedalus-v4l2 (a misc-class character device)
|
|
* for the userspace daemon to attach to. Single-instance:
|
|
* only one open file at a time. Blocking read() pulls the next
|
|
* request from a kernel-side FIFO; write() submits a response.
|
|
*
|
|
* Phase 8.2 scope: PING request handling — the daemon writes a
|
|
* PONG response to a PING request that arrives via read(). In
|
|
* Phase 8.2 the kernel injects test PING requests itself via a
|
|
* debugfs trigger (no V4L2 ioctl flow yet); Phase 8.4 wires
|
|
* real DECODE requests from the V4L2 path.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/miscdevice.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/wait.h>
|
|
#include <linux/list.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/uaccess.h>
|
|
#include <linux/poll.h>
|
|
#include <linux/debugfs.h>
|
|
|
|
#include "daedalus_v4l2_proto.h"
|
|
#include "daedalus_v4l2_chardev.h"
|
|
|
|
#define DAEDALUS_CHARDEV_NAME "daedalus-v4l2"
|
|
|
|
/* Cap the number of pending requests so a stuck daemon can't OOM us. */
|
|
#define DAEDALUS_QUEUE_MAX 64
|
|
|
|
/**
|
|
* struct daedalus_chardev_msg - in-kernel queued message
|
|
* @list: queue linkage
|
|
* @hdr: wire header
|
|
* @payload: payload bytes; size = hdr.payload_len
|
|
*/
|
|
struct daedalus_chardev_msg {
|
|
struct list_head list;
|
|
struct daedalus_msg_hdr hdr;
|
|
u8 *payload;
|
|
};
|
|
|
|
/**
|
|
* struct daedalus_chardev - per-singleton chardev state
|
|
* @misc: misc-class device registration
|
|
* @open_lock: serialises open()/release()
|
|
* @opened: non-zero when the chardev is currently open
|
|
* @req_lock: protects @req_queue / @req_count
|
|
* @req_queue: list of pending REQ_* messages waiting for daemon read()
|
|
* @req_count: current number of queued requests
|
|
* @req_wait: read() blocks here until a request arrives
|
|
*/
|
|
struct daedalus_chardev {
|
|
struct miscdevice misc;
|
|
struct mutex open_lock;
|
|
int opened;
|
|
struct mutex req_lock;
|
|
struct list_head req_queue;
|
|
int req_count;
|
|
wait_queue_head_t req_wait;
|
|
struct dentry *debugfs_dir;
|
|
};
|
|
|
|
static struct daedalus_chardev *g_chardev;
|
|
|
|
/* -- internal helpers ------------------------------------------------ */
|
|
|
|
static struct daedalus_chardev_msg *
|
|
daedalus_chardev_dequeue_locked(struct daedalus_chardev *dev)
|
|
{
|
|
struct daedalus_chardev_msg *msg;
|
|
|
|
if (list_empty(&dev->req_queue))
|
|
return NULL;
|
|
msg = list_first_entry(&dev->req_queue,
|
|
struct daedalus_chardev_msg, list);
|
|
list_del(&msg->list);
|
|
dev->req_count--;
|
|
return msg;
|
|
}
|
|
|
|
static void daedalus_chardev_msg_free(struct daedalus_chardev_msg *msg)
|
|
{
|
|
if (!msg)
|
|
return;
|
|
kfree(msg->payload);
|
|
kfree(msg);
|
|
}
|
|
|
|
int daedalus_chardev_enqueue_req(u32 type, u32 cookie,
|
|
const void *payload, size_t payload_len)
|
|
{
|
|
struct daedalus_chardev *dev = g_chardev;
|
|
struct daedalus_chardev_msg *msg;
|
|
|
|
if (!dev)
|
|
return -ENODEV;
|
|
if (payload_len > DAEDALUS_PROTO_MAX_PAYLOAD)
|
|
return -EMSGSIZE;
|
|
if (type & 0x80000000u) /* responses don't get queued here */
|
|
return -EINVAL;
|
|
|
|
msg = kzalloc(sizeof(*msg), GFP_KERNEL);
|
|
if (!msg)
|
|
return -ENOMEM;
|
|
if (payload_len) {
|
|
msg->payload = kmemdup(payload, payload_len, GFP_KERNEL);
|
|
if (!msg->payload) {
|
|
kfree(msg);
|
|
return -ENOMEM;
|
|
}
|
|
}
|
|
msg->hdr.magic = DAEDALUS_PROTO_MAGIC;
|
|
msg->hdr.version = DAEDALUS_PROTO_VERSION;
|
|
msg->hdr.type = type;
|
|
msg->hdr.cookie = cookie;
|
|
msg->hdr.payload_len = (u32) payload_len;
|
|
msg->hdr.reserved = 0;
|
|
|
|
mutex_lock(&dev->req_lock);
|
|
if (dev->req_count >= DAEDALUS_QUEUE_MAX) {
|
|
mutex_unlock(&dev->req_lock);
|
|
daedalus_chardev_msg_free(msg);
|
|
return -ENOSPC;
|
|
}
|
|
list_add_tail(&msg->list, &dev->req_queue);
|
|
dev->req_count++;
|
|
mutex_unlock(&dev->req_lock);
|
|
wake_up_interruptible(&dev->req_wait);
|
|
return 0;
|
|
}
|
|
|
|
/* -- file operations ------------------------------------------------- */
|
|
|
|
static int daedalus_chardev_open(struct inode *inode, struct file *file)
|
|
{
|
|
struct daedalus_chardev *dev = g_chardev;
|
|
|
|
mutex_lock(&dev->open_lock);
|
|
if (dev->opened) {
|
|
mutex_unlock(&dev->open_lock);
|
|
return -EBUSY;
|
|
}
|
|
dev->opened = 1;
|
|
mutex_unlock(&dev->open_lock);
|
|
file->private_data = dev;
|
|
return 0;
|
|
}
|
|
|
|
static int daedalus_chardev_release(struct inode *inode, struct file *file)
|
|
{
|
|
struct daedalus_chardev *dev = file->private_data;
|
|
struct daedalus_chardev_msg *msg;
|
|
|
|
mutex_lock(&dev->req_lock);
|
|
while ((msg = daedalus_chardev_dequeue_locked(dev)) != NULL) {
|
|
mutex_unlock(&dev->req_lock);
|
|
daedalus_chardev_msg_free(msg);
|
|
mutex_lock(&dev->req_lock);
|
|
}
|
|
mutex_unlock(&dev->req_lock);
|
|
|
|
mutex_lock(&dev->open_lock);
|
|
dev->opened = 0;
|
|
mutex_unlock(&dev->open_lock);
|
|
return 0;
|
|
}
|
|
|
|
static ssize_t daedalus_chardev_read(struct file *file, char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
struct daedalus_chardev *dev = file->private_data;
|
|
struct daedalus_chardev_msg *msg;
|
|
size_t total;
|
|
int ret;
|
|
|
|
if (count < sizeof(struct daedalus_msg_hdr))
|
|
return -EINVAL;
|
|
|
|
for (;;) {
|
|
mutex_lock(&dev->req_lock);
|
|
msg = daedalus_chardev_dequeue_locked(dev);
|
|
mutex_unlock(&dev->req_lock);
|
|
if (msg)
|
|
break;
|
|
if (file->f_flags & O_NONBLOCK)
|
|
return -EAGAIN;
|
|
ret = wait_event_interruptible(dev->req_wait,
|
|
dev->req_count > 0);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
total = sizeof(msg->hdr) + msg->hdr.payload_len;
|
|
if (count < total) {
|
|
/*
|
|
* Requeue so the caller can retry with a bigger buffer.
|
|
* Re-enqueue at HEAD to preserve FIFO order.
|
|
*/
|
|
mutex_lock(&dev->req_lock);
|
|
list_add(&msg->list, &dev->req_queue);
|
|
dev->req_count++;
|
|
mutex_unlock(&dev->req_lock);
|
|
return -EMSGSIZE;
|
|
}
|
|
|
|
if (copy_to_user(buf, &msg->hdr, sizeof(msg->hdr))) {
|
|
daedalus_chardev_msg_free(msg);
|
|
return -EFAULT;
|
|
}
|
|
if (msg->hdr.payload_len &&
|
|
copy_to_user(buf + sizeof(msg->hdr), msg->payload,
|
|
msg->hdr.payload_len)) {
|
|
daedalus_chardev_msg_free(msg);
|
|
return -EFAULT;
|
|
}
|
|
|
|
daedalus_chardev_msg_free(msg);
|
|
return total;
|
|
}
|
|
|
|
static ssize_t daedalus_chardev_write(struct file *file,
|
|
const char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
struct daedalus_msg_hdr hdr;
|
|
u8 *payload = NULL;
|
|
size_t expected;
|
|
|
|
if (count < sizeof(hdr))
|
|
return -EINVAL;
|
|
if (copy_from_user(&hdr, buf, sizeof(hdr)))
|
|
return -EFAULT;
|
|
if (hdr.magic != DAEDALUS_PROTO_MAGIC)
|
|
return -EBADMSG;
|
|
if (hdr.version != DAEDALUS_PROTO_VERSION)
|
|
return -EPROTO;
|
|
if (hdr.payload_len > DAEDALUS_PROTO_MAX_PAYLOAD)
|
|
return -EMSGSIZE;
|
|
expected = sizeof(hdr) + hdr.payload_len;
|
|
if (count < expected)
|
|
return -EINVAL;
|
|
|
|
if (hdr.payload_len) {
|
|
payload = kmalloc(hdr.payload_len, GFP_KERNEL);
|
|
if (!payload)
|
|
return -ENOMEM;
|
|
if (copy_from_user(payload, buf + sizeof(hdr),
|
|
hdr.payload_len)) {
|
|
kfree(payload);
|
|
return -EFAULT;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Response dispatch. Phase 8.4 understands PONG (echoes
|
|
* back at debug level) and RESP_FRAME (logs decode result
|
|
* at info so the test harness can see it without enabling
|
|
* dyndbg). Phase 8.5+ will wire RESP_FRAME to the V4L2
|
|
* buffer-done path.
|
|
*/
|
|
switch (hdr.type) {
|
|
case DAEDALUS_MSG_RESP_FRAME: {
|
|
struct daedalus_resp_frame fr;
|
|
|
|
if (hdr.payload_len < sizeof(fr)) {
|
|
pr_warn("daedalus_v4l2: RESP_FRAME payload too short (%u < %zu)\n",
|
|
hdr.payload_len, sizeof(fr));
|
|
kfree(payload);
|
|
return -EBADMSG;
|
|
}
|
|
memcpy(&fr, payload, sizeof(fr));
|
|
pr_info("daedalus_v4l2: RESP_FRAME cookie=%u status=%u codec=%u %ux%u pixfmt=%d luma=%u chroma=%u fnv1a=0x%08x\n",
|
|
hdr.cookie, fr.status, fr.codec_id,
|
|
fr.width, fr.height, fr.pix_fmt,
|
|
fr.luma_len, fr.chroma_len, fr.fnv1a_yuv);
|
|
break;
|
|
}
|
|
default:
|
|
pr_debug("daedalus_v4l2: chardev got response type=0x%08x cookie=%u plen=%u\n",
|
|
hdr.type, hdr.cookie, hdr.payload_len);
|
|
break;
|
|
}
|
|
|
|
kfree(payload);
|
|
return expected;
|
|
}
|
|
|
|
static __poll_t daedalus_chardev_poll(struct file *file,
|
|
struct poll_table_struct *wait)
|
|
{
|
|
struct daedalus_chardev *dev = file->private_data;
|
|
__poll_t mask = EPOLLOUT | EPOLLWRNORM;
|
|
|
|
poll_wait(file, &dev->req_wait, wait);
|
|
if (READ_ONCE(dev->req_count) > 0)
|
|
mask |= EPOLLIN | EPOLLRDNORM;
|
|
return mask;
|
|
}
|
|
|
|
/*
|
|
* .llseek intentionally unset. The chardev is a streaming
|
|
* request/response channel; no positional semantics. Recent
|
|
* kernels removed `no_llseek`; leaving the slot NULL gets the
|
|
* generic "no-op or -ESPIPE" behaviour the v6.12+ vfs picks.
|
|
*/
|
|
static const struct file_operations daedalus_chardev_fops = {
|
|
.owner = THIS_MODULE,
|
|
.open = daedalus_chardev_open,
|
|
.release = daedalus_chardev_release,
|
|
.read = daedalus_chardev_read,
|
|
.write = daedalus_chardev_write,
|
|
.poll = daedalus_chardev_poll,
|
|
};
|
|
|
|
/* -- debugfs test trigger (Phase 8.2 only) --------------------------- */
|
|
/*
|
|
* Writing any non-zero byte stream to
|
|
* /sys/kernel/debug/daedalus_v4l2/test_ping enqueues a PING
|
|
* request with a fixed 24-byte payload "DAEDALUS-V4L2-PING-PL\0\0\0".
|
|
* The userspace test daemon (tools/test_chardev_pingpong.c)
|
|
* then reads it back, sends PONG, and the kernel logs the
|
|
* round-trip at pr_debug level.
|
|
*
|
|
* Phase 8.4 replaces this with real REQ_DECODE injection from
|
|
* the V4L2 buffer-submit path; the debugfs entry can be removed
|
|
* then.
|
|
*/
|
|
static ssize_t daedalus_test_ping_write(struct file *file,
|
|
const char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
static const char payload[24] = "DAEDALUS-V4L2-PING-PL";
|
|
int ret;
|
|
|
|
ret = daedalus_chardev_enqueue_req(DAEDALUS_MSG_PING, 0x1234u,
|
|
payload, sizeof(payload));
|
|
if (ret)
|
|
return ret;
|
|
return count;
|
|
}
|
|
|
|
static const struct file_operations daedalus_test_ping_fops = {
|
|
.owner = THIS_MODULE,
|
|
.write = daedalus_test_ping_write,
|
|
};
|
|
|
|
/*
|
|
* Writing bitstream bytes to
|
|
* /sys/kernel/debug/daedalus_v4l2/test_decode enqueues a REQ_DECODE
|
|
* carrying those bytes as a VP9 access unit (Phase 8.4 fixed
|
|
* codec). The wire payload prepends a struct daedalus_req_decode
|
|
* header so the daemon knows the codec id and bitstream length.
|
|
*
|
|
* Phase 8.6 generalises codec_id (via a sysfs / debugfs control);
|
|
* for Phase 8.4 VP9 is hard-wired since that's what the cycle-9
|
|
* stack targets first.
|
|
*/
|
|
static atomic_t daedalus_decode_cookie = ATOMIC_INIT(0);
|
|
|
|
static ssize_t daedalus_test_decode_write(struct file *file,
|
|
const char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
struct daedalus_req_decode req;
|
|
u8 *blob;
|
|
size_t total;
|
|
u32 cookie;
|
|
int ret;
|
|
|
|
if (count == 0)
|
|
return -EINVAL;
|
|
if (count + sizeof(req) > DAEDALUS_PROTO_MAX_PAYLOAD)
|
|
return -EMSGSIZE;
|
|
|
|
total = sizeof(req) + count;
|
|
blob = kmalloc(total, GFP_KERNEL);
|
|
if (!blob)
|
|
return -ENOMEM;
|
|
|
|
req.codec_id = DAEDALUS_CODEC_VP9;
|
|
req.bitstream_len = (u32) count;
|
|
req.flags = 0;
|
|
memcpy(blob, &req, sizeof(req));
|
|
|
|
if (copy_from_user(blob + sizeof(req), buf, count)) {
|
|
kfree(blob);
|
|
return -EFAULT;
|
|
}
|
|
|
|
cookie = (u32) atomic_inc_return(&daedalus_decode_cookie);
|
|
ret = daedalus_chardev_enqueue_req(DAEDALUS_MSG_REQ_DECODE, cookie,
|
|
blob, total);
|
|
kfree(blob);
|
|
if (ret)
|
|
return ret;
|
|
|
|
pr_info("daedalus_v4l2: REQ_DECODE enqueued cookie=%u codec=VP9 bitstream=%zu\n",
|
|
cookie, count);
|
|
return count;
|
|
}
|
|
|
|
static const struct file_operations daedalus_test_decode_fops = {
|
|
.owner = THIS_MODULE,
|
|
.write = daedalus_test_decode_write,
|
|
};
|
|
|
|
/* -- registration ---------------------------------------------------- */
|
|
|
|
int daedalus_chardev_init(void)
|
|
{
|
|
struct daedalus_chardev *dev;
|
|
int ret;
|
|
|
|
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
|
|
if (!dev)
|
|
return -ENOMEM;
|
|
mutex_init(&dev->open_lock);
|
|
mutex_init(&dev->req_lock);
|
|
INIT_LIST_HEAD(&dev->req_queue);
|
|
init_waitqueue_head(&dev->req_wait);
|
|
|
|
dev->misc.minor = MISC_DYNAMIC_MINOR;
|
|
dev->misc.name = DAEDALUS_CHARDEV_NAME;
|
|
dev->misc.fops = &daedalus_chardev_fops;
|
|
dev->misc.mode = 0660; /* root:video, like /dev/videoNN */
|
|
|
|
ret = misc_register(&dev->misc);
|
|
if (ret) {
|
|
kfree(dev);
|
|
return ret;
|
|
}
|
|
|
|
dev->debugfs_dir = debugfs_create_dir("daedalus_v4l2", NULL);
|
|
if (!IS_ERR(dev->debugfs_dir)) {
|
|
debugfs_create_file("test_ping", 0200, dev->debugfs_dir,
|
|
NULL, &daedalus_test_ping_fops);
|
|
debugfs_create_file("test_decode", 0200, dev->debugfs_dir,
|
|
NULL, &daedalus_test_decode_fops);
|
|
}
|
|
|
|
g_chardev = dev;
|
|
pr_info("daedalus_v4l2: /dev/%s registered\n", DAEDALUS_CHARDEV_NAME);
|
|
return 0;
|
|
}
|
|
|
|
void daedalus_chardev_exit(void)
|
|
{
|
|
struct daedalus_chardev *dev = g_chardev;
|
|
struct daedalus_chardev_msg *msg;
|
|
|
|
if (!dev)
|
|
return;
|
|
debugfs_remove_recursive(dev->debugfs_dir);
|
|
misc_deregister(&dev->misc);
|
|
|
|
while ((msg = list_first_entry_or_null(&dev->req_queue,
|
|
struct daedalus_chardev_msg,
|
|
list)) != NULL) {
|
|
list_del(&msg->list);
|
|
daedalus_chardev_msg_free(msg);
|
|
}
|
|
mutex_destroy(&dev->req_lock);
|
|
mutex_destroy(&dev->open_lock);
|
|
kfree(dev);
|
|
g_chardev = NULL;
|
|
}
|